[BUG] Outliers in gempy v3 #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Add gempy label" took an action on this PR • (03/26/25)1 label was added to this PR based on Miguel de la Varga's automation. |
|
Yeah, I have noticed that issue as well. Had some additional lith ids there suddenly |
Hi @AlexanderJuestel, just to make sure - did you encounter completely new IDs? So far I have only seen existing elements out of place (like in the screenshot above). |
|
I have actually encountered new IDs |
|
Thanks for opening this. This makes so much easier to chase these things. For now I mark it as draft since it is not meant to be reviewed. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the release of gempy v3 we noticed some outliers in the lithology block. These are basically single cells that have a wrong element ID in the lithology block. They generally appear close to surface boundaries and are appearing depending on resolution. This might be caused when mapping sclar field values to int for the lithology block.
As I don't think the isse is related to Octrees or DC I opened a new pull request. This issue will cause problems when reintroducing MC as a meshing approach in #1000 and #1006 .
For now I added a single example as a test (see screenshot). I will add more examples whe I come across them and have time.
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).